Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757752AbZLEEhn (ORCPT ); Fri, 4 Dec 2009 23:37:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757712AbZLEEhm (ORCPT ); Fri, 4 Dec 2009 23:37:42 -0500 Received: from g4t0014.houston.hp.com ([15.201.24.17]:21049 "EHLO g4t0014.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757701AbZLEEhl (ORCPT ); Fri, 4 Dec 2009 23:37:41 -0500 Date: Fri, 4 Dec 2009 21:37:47 -0700 From: Alex Chiang To: Rakib Mullick Cc: Jesse Barnes , linux-pci@vger.kernel.org, LKML , Andrew Morton Subject: Re: [PATCH] pci: Make pci_dev struct point to NULL. Message-ID: <20091205043747.GB10777@ldl.fc.hp.com> References: <20091204202709.GA32347@ldl.fc.hp.com> <20091205043635.GA10777@ldl.fc.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091205043635.GA10777@ldl.fc.hp.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 27 * Alex Chiang : > * Rakib Mullick : > > On 12/5/09, Alex Chiang wrote: > > > * Rakib Mullick : > > > > > > This is from Linus's latest tree: > > > > > > 974 > > > 975 if (slot->flags & SLOT_ENABLED) > > > 976 goto err_exit; > > > > I'm talking about this line. From here we can hit 'goto err_exit' without > > using pci_get_slot. > > Right, so what's the problem? If the slot is not enabled, we goto > err_exit and return, never touching dev. Whoops, of course I meant if the slot is already enabled, then we return early. /ac -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/