DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=GDqN1noXY9ZFY9okMLz+DGQFRNZmUYI3w+E5Gma3HioduibScdIGA1AQsj2LbHMNHI
         QBLstHQtQnTaA/tRQjYuVCPqVZbG/wUKEGxFVc4njkQ+F8eOLe3pwy6rE5H5XVXGoKxl
         E6b2eQEZbEQ/WyBhPaV8jw8yS+2OrgXRq+VQc=
MIME-Version: 1.0
In-Reply-To: <20091205043635.GA10777@ldl.fc.hp.com>
References: <b9df5fa10912040835k3e23702o8700d2d8ad2349a4@mail.gmail.com>
	 <20091204202709.GA32347@ldl.fc.hp.com>
	 <b9df5fa10912041753n27e60020x2dd41eb50f4608ff@mail.gmail.com>
	 <20091205043635.GA10777@ldl.fc.hp.com>
Date: Sat, 5 Dec 2009 11:18:05 +0600
Message-ID: <b9df5fa10912042118p733416ffwe21b79b1f8246f2f@mail.gmail.com>
Subject: Re: [PATCH] pci: Make pci_dev struct point to NULL.
From: Rakib Mullick <rakib.mullick@gmail.com>
To: Alex Chiang <achiang@hp.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>, linux-pci@vger.kernel.org,
       LKML <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 833
Lines: 32

On 12/5/09, Alex Chiang <achiang@hp.com> wrote:
> * Rakib Mullick <rakib.mullick@gmail.com>:
>  > On 12/5/09, Alex Chiang <achiang@hp.com> wrote:
>  > > * Rakib Mullick <rakib.mullick@gmail.com>:
>
>
> Right, so what's the problem? If the slot is not enabled, we goto
>  err_exit and return, never touching dev.
>
>
> I must be slow, because I don't understand how we might reference
>  trash.
>
Since *pdev might be uninitialized. But if we are sure that it is not
uninitialized
then it is okay.

And yes - althrough we weren't warned by the compiler.

Thanks,

>
>  Thanks,
>
> /ac
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/