Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754826AbZLEMvR (ORCPT ); Sat, 5 Dec 2009 07:51:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754558AbZLEMvO (ORCPT ); Sat, 5 Dec 2009 07:51:14 -0500 Received: from mail-yx0-f187.google.com ([209.85.210.187]:61667 "EHLO mail-yx0-f187.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754527AbZLEMvO (ORCPT ); Sat, 5 Dec 2009 07:51:14 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=djXc64Mm/jzCYGhsSk27kurfBM/2Y9erSodOTwldDmGzlSPJ4Ykeb+HCBUoEh/rx2r ro3PHbgm+lUOy+2rqlHlV1bTkMwBWp9I5ADy/VHrE0uXaf38PaKX97dGYSQKjMjLmuib gOsIqvjLaVpKFt+WJIvjOODvHzkIf5J76wAk0= Message-ID: <4B1A557D.4080707@gmail.com> Date: Sat, 05 Dec 2009 07:43:41 -0500 From: William Allen Simpson User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Joe Perches CC: Brice Goglin , David Miller , netdev@vger.kernel.org, Linux Kernel Developers Subject: Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of previous line References: <1259001504.16503.79.camel@Joe-Laptop.home> <20091123.104130.117837098.davem@davemloft.net> <1259528449.29779.194.camel@Joe-Laptop.home> <20091129.165557.84377714.davem@davemloft.net> <1259863101.22783.63.camel@Joe-Laptop.home> <4B190A29.5080905@myri.com> <1259947271.22783.120.camel@Joe-Laptop.home> In-Reply-To: <1259947271.22783.120.camel@Joe-Laptop.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 26 Joe Perches wrote: > On Fri, 2009-12-04 at 14:10 +0100, Brice Goglin wrote: >> Joe Perches wrote: >>> Only files where David Miller is the primary git-signer. >>> wireless, wimax, ixgbe, etc are not modified. >> What's the point? Having them at the beginning of the next line is >> easier to read from my point of view. > > It's just a stupid consistency thing. > Brice, I've made my objection known on the LKML. Joe *agrees* that having them on the beginning of the line is preferred. Thousands of contributors throughout the tree agree. This is entirely a Miller thing. My main objection to these sweeping patches is that it makes it much more difficult to maintain and apply patches across different versions of the tree. We have already seen conflicts with other git maintained trees. These patches should not be accepted to the main Linus tree. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/