Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <4B19A92A.5030804@analog.com>
References: <4B19A92A.5030804@analog.com> <1244854869-2563-1-git-send-email-vapier@gentoo.org> <14959.1259948697@redhat.com>
To: Jie Zhang <jie.zhang@analog.com>
Cc: dhowells@redhat.com, uClinux development list <uclinux-dev@uclinux.org>,
       linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
       uclinux-dist-devel@blackfin.uclinux.org,
       David McCullough <davidm@snapgear.com>
Subject: Re: [uClinux-dev] [PATCH/RFC] FDPIC: add hook for arches to customize program header parsing
Date: Sat, 05 Dec 2009 15:14:34 +0000
Message-ID: <643.1260026074@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 987
Lines: 23

Jie Zhang <jie.zhang@analog.com> wrote:

> > There needs to be a mapping covering the SRAM region for the purposes of the
> 
> Our GDB is still lack of the feature to debug applications using SRAM. So this
> part of code was not got exercised. So if we remove this line, can this patch
> got merged?

No.  Firstly, the piece of storage that gets munmapped isn't used, so unmapping
it isn't wrong.  What you need to do is to put a mapping over the bit of the
SRAM you wish to use and then fill it and use it.  Ideally, you'd do this
inside of do_mmap_pgoff() - that way those bits of the SRAM can be shared, but
I'm not sure how best to do that.

But you need to stick a VMA over it so that various checks don't spit
EFAULT/EIO at you.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/