Message-ID: <4B1B6CB8.7000107@gmail.com>
Date: Sun, 06 Dec 2009 09:35:04 +0100
From: Eric Dumazet <eric.dumazet@gmail.com>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: Joe Perches <joe@perches.com>
CC: Andy Whitcroft <apw@canonical.com>, David Miller <davem@davemloft.net>,
       LKML <linux-kernel@vger.kernel.org>,
       William Allen Simpson <william.allen.simpson@gmail.com>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add warning about leading contination
 tests
References: <1260035884.11126.58.camel@Joe-Laptop.home>
In-Reply-To: <1260035884.11126.58.camel@Joe-Laptop.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1029
Lines: 29

Joe Perches a écrit :
> Signed-off-by: Joe Perches <joe@perches.com>
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index bc4114f..c35933a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2064,6 +2064,11 @@ sub process {
>  			CHK("multiple assignments should be avoided\n" . $herecurr);
>  		}
>  
> +# Check use of leading logical continuation tests
> +		if ($line =~ /^.\s*(\|\||&&)/) {
> +			WARN("Continuation logic should be at end of previous line\n" . $herecurr);
> +		}
> +
>  ## # check for multiple declarations, allowing for a function declaration
>  ## # continuation.
>  ## 		if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
> 
> 

Fine with me, but please add relevant info in Documentation/CodingStyle ?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/