Date: Sun, 6 Dec 2009 12:54:58 +0100
From: Ingo Molnar <mingo@elte.hu>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
       Arjan van de Ven <arjan@infradead.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Paul Mackerras <paulus@samba.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] perf: Fix timechart header handling
Message-ID: <20091206115458.GA21964@elte.hu>
References: <87ljhg8ioe.fsf@devron.myhome.or.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ljhg8ioe.fsf@devron.myhome.or.jp>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 807
Lines: 28


* OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:

> Hi,
> 
> Update "struct trace_entry" to match with current one. And remove
> "size" field from it.
> 
> If it has "size", it become cause of alignment mismatch of structure
> with kernel.
> 
> Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> 
>  tools/perf/builtin-timechart.c |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

Just curious, have you tested timechart functionality after having done 
this change - does it still work fine for you?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/