Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933161AbZLGDes (ORCPT ); Sun, 6 Dec 2009 22:34:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933134AbZLGDer (ORCPT ); Sun, 6 Dec 2009 22:34:47 -0500 Received: from ns.dcl.info.waseda.ac.jp ([133.9.216.194]:64414 "EHLO ns.dcl.info.waseda.ac.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933113AbZLGDeq (ORCPT ); Sun, 6 Dec 2009 22:34:46 -0500 From: Hitoshi Mitake To: Ingo Molnar , Frederic Weisbecker Cc: linux-kernel@vger.kernel.org, Hitoshi Mitake , Frederic Weisbecker , Peter Zijlstra , Paul Mackerras , Tom Zanussi , Steven Rostedt Subject: [PATCH 1/2] Does raw_field_ptr() supports __data_loc? Date: Mon, 7 Dec 2009 12:34:43 +0900 Message-Id: <1260156884-8474-1-git-send-email-mitake@dcl.info.waseda.ac.jp> X-Mailer: git-send-email 1.6.5.2 In-Reply-To: <20091115022135.GA5427@nowhere> References: <20091115022135.GA5427@nowhere> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1710 Lines: 54 VERY very sorry for my long silence... Please don't commit this patch, Ingo. This patch is required to test the next patch for perf lock. I have a question for Steven Rostedt and Tom Zanussi. Does current raw_field_ptr() support __data_loc? At 064739bc4b3d7f424b2f25547e6611bcf0132415 , support for the modifier "__data_loc" of format is added. But, when I wanted to parse format of lock_acquired (or some event else), raw_field_ptr() did not returned correct pointer. So I modified raw_field_ptr() like this patch. Then raw_field_ptr() works well. Parser was large so I'd like to ask you about this. Cc: Frederic Weisbecker Cc: Peter Zijlstra Cc: Paul Mackerras Cc: Tom Zanussi Cc: Steven Rostedt I have a question --- tools/perf/util/trace-event-parse.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c index 0302405..494a470 100644 --- a/tools/perf/util/trace-event-parse.c +++ b/tools/perf/util/trace-event-parse.c @@ -1925,6 +1925,13 @@ void *raw_field_ptr(struct event *event, const char *name, void *data) if (!field) return NULL; + if (field->flags & FIELD_IS_STRING) { + int offset; + offset = *(int *)(data + field->offset); + offset &= 0xffff; + return data + offset; + } + return data + field->offset; } -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/