Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751207AbZLGFTI (ORCPT ); Mon, 7 Dec 2009 00:19:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751122AbZLGFTH (ORCPT ); Mon, 7 Dec 2009 00:19:07 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:41413 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbZLGFTG (ORCPT ); Mon, 7 Dec 2009 00:19:06 -0500 From: OGAWA Hirofumi To: Xiao Guangrong Cc: Ingo Molnar , Frederic Weisbecker , Paul Mackerras , Peter Zijlstra , Li Zefan , LKML Subject: Re: [PATCH 3/3] perf_event: fix __dsos__write_buildid_table() References: <4B1C7EE1.8030906@cn.fujitsu.com> <4B1C7F45.5080105@cn.fujitsu.com> <4B1C7F73.80707@cn.fujitsu.com> Date: Mon, 07 Dec 2009 14:19:06 +0900 In-Reply-To: <4B1C7F73.80707@cn.fujitsu.com> (Xiao Guangrong's message of "Mon, 07 Dec 2009 12:07:15 +0800") Message-ID: <87r5r74b05.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1573 Lines: 43 Xiao Guangrong writes: > The remain buff size is 'len - pos->long_name_len - 1', not > 'len - pos->long_name_len + 1' > > This bug is imported by: > Commit-ID: 7691b1ec2e4a8d4bd88dcf88b29792399ebe1c91 > Gitweb: http://git.kernel.org/tip/7691b1ec2e4a8d4bd88dcf88b29792399ebe1c91 > Author: OGAWA Hirofumi > AuthorDate: Sun, 6 Dec 2009 20:10:49 +0900 > Committer: Ingo Molnar > CommitDate: Sun, 6 Dec 2009 18:15:02 +0100 > > perf tools: Misc small fixes Oops, I forgot parens. Thanks for fixing it. > Signed-off-by: Xiao Guangrong > --- > tools/perf/util/header.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > index 08b6759..59a9c0b 100644 > --- a/tools/perf/util/header.c > +++ b/tools/perf/util/header.c > @@ -209,7 +209,7 @@ static int __dsos__write_buildid_table(struct list_head *head, int fd) > err = do_write(fd, pos->long_name, pos->long_name_len + 1); > if (err < 0) > return err; > - err = do_write(fd, zero_buf, len - pos->long_name_len + 1); > + err = do_write(fd, zero_buf, len - pos->long_name_len - 1); > if (err < 0) > return err; > } -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/