Date: Mon, 7 Dec 2009 08:10:08 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Ulrich Drepper <drepper@redhat.com>
Cc: a.p.zijlstra@chello.nl, fweisbec@gmail.com, jaswinderrajput@gmail.com,
       linux-kernel@vger.kernel.org, paulus@samba.org
Subject: Re: Minor optimization in parse_subsystem_tracepoint_event
Message-ID: <20091207071008.GE10868@elte.hu>
References: <200912061825.nB6IPUa1023306@hs20-bc2-1.build.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200912061825.nB6IPUa1023306@hs20-bc2-1.build.redhat.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 750
Lines: 20


* Ulrich Drepper <drepper@redhat.com> wrote:

> Uses of strcat are almost always signs that someone is too lazy to think
> about the code a bit more carefully.  One always has to know about the
> lengths of the strings involved to avoid buffer overflows.
> 
> This is one case where the size of the object code for me is reduced by
> 38 bytes.  The code should also be faster, especially if flags is non-NULL.
> 
> Signed-off-by: Ulrich Drepper <drepper@redhat.com>

Applied, thanks a lot Ulrich!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/