Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758975AbZLGHpY (ORCPT ); Mon, 7 Dec 2009 02:45:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758962AbZLGHpX (ORCPT ); Mon, 7 Dec 2009 02:45:23 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:65462 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1758827AbZLGHpW (ORCPT ); Mon, 7 Dec 2009 02:45:22 -0500 Message-ID: <4B1CB27E.4000709@cn.fujitsu.com> Date: Mon, 07 Dec 2009 15:45:02 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Ingo Molnar CC: Steven Rostedt , Frederic Weisbecker , LKML , "K.Prasad" Subject: [PATCH 13/13] ksym_tracer: Fix compile warnings References: <4B1CB14A.4080402@cn.fujitsu.com> In-Reply-To: <4B1CB14A.4080402@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2503 Lines: 70 Fix these 2 warnings: kernel/trace/trace_ksym.c: In function 'ksym_trace_filter_read': kernel/trace/trace_ksym.c:239: warning: cast to pointer from integer of different size kernel/trace/trace_ksym.c: In function 'ksym_trace_filter_write': kernel/trace/trace_ksym.c:295: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result Signed-off-by: Li Zefan --- kernel/trace/trace_ksym.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/kernel/trace/trace_ksym.c b/kernel/trace/trace_ksym.c index acb87d4..e393146 100644 --- a/kernel/trace/trace_ksym.c +++ b/kernel/trace/trace_ksym.c @@ -236,7 +236,8 @@ static ssize_t ksym_trace_filter_read(struct file *filp, char __user *ubuf, mutex_lock(&ksym_tracer_mutex); hlist_for_each_entry(entry, node, &ksym_filter_head, ksym_hlist) { - ret = trace_seq_printf(s, "%pS:", (void *)entry->attr.bp_addr); + ret = trace_seq_printf(s, "%pS:", + (void *)(unsigned long)entry->attr.bp_addr); if (entry->attr.bp_type == HW_BREAKPOINT_R) ret = trace_seq_puts(s, "r--\n"); else if (entry->attr.bp_type == HW_BREAKPOINT_W) @@ -278,7 +279,7 @@ static ssize_t ksym_trace_filter_write(struct file *file, { struct trace_ksym *entry; struct hlist_node *node; - char *input_string, *ksymname = NULL; + char *input_string, *buf, *ksymname = NULL; unsigned long ksym_addr = 0; int ret, op, changed = 0; @@ -292,7 +293,7 @@ static ssize_t ksym_trace_filter_write(struct file *file, } input_string[count] = '\0'; - strstrip(input_string); + buf = strstrip(input_string); /* * Clear all breakpoints if: @@ -300,14 +301,14 @@ static ssize_t ksym_trace_filter_write(struct file *file, * 2: echo 0 > ksym_trace_filter * 3: echo "*:---" > ksym_trace_filter */ - if (!input_string[0] || !strcmp(input_string, "0") || - !strcmp(input_string, "*:---")) { + if (!buf[0] || !strcmp(buf, "0") || + !strcmp(buf, "*:---")) { __ksym_trace_reset(); kfree(input_string); return count; } - ret = op = parse_ksym_trace_str(input_string, &ksymname, &ksym_addr); + ret = op = parse_ksym_trace_str(buf, &ksymname, &ksym_addr); if (ret < 0) { kfree(input_string); return ret; -- 1.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/