Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934793AbZLGMVm (ORCPT ); Mon, 7 Dec 2009 07:21:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757359AbZLGMVk (ORCPT ); Mon, 7 Dec 2009 07:21:40 -0500 Received: from bamako.nerim.net ([62.4.17.28]:60178 "EHLO bamako.nerim.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757133AbZLGMVh (ORCPT ); Mon, 7 Dec 2009 07:21:37 -0500 Date: Mon, 7 Dec 2009 13:21:41 +0100 From: Jean Delvare To: Ben Dooks Cc: netdev@vger.kernel.org, linux@simtec.co.uk, doong.ping@micrel.com, tristram.ha@micrel.com, Wolfram Sang , Linux Kernel Subject: Re: [patch 1/9] eeprom_93cx6: Add data direction control. Message-ID: <20091207132141.1db65cd3@hyperion.delvare> In-Reply-To: <20091207121827.433183360@fluff.org.uk> References: <20091207121727.016092171@fluff.org.uk> <20091207121827.433183360@fluff.org.uk> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i586-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 25 On Mon, 07 Dec 2009 12:17:28 +0000, Ben Dooks wrote: > Some devices need to know if the data is to be output or read, so add a > data direction into the eeprom structure to tell the driver whether the > data line should be driven. > > The user in this case is the Micrel KS8851 which has a direction > control for the EEPROM data line and thus needs to know whether > to drive it (writing) or to tristate it for receiving. > > Signed-off-by: Ben Dooks > Cc: Wolfram Sang > Cc: Jean Delvare > Cc: Linux Kernel FYI, I will not be reviewing this patch nor any other patch to the eeprom_93cx6 driver. I have no clue what these devices are, no access to any and no interest in them either. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/