Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757535AbZLGNIR (ORCPT ); Mon, 7 Dec 2009 08:08:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757004AbZLGNIP (ORCPT ); Mon, 7 Dec 2009 08:08:15 -0500 Received: from fxip-0047f.externet.hu ([88.209.222.127]:58796 "EHLO pomaz-ex.szeredi.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753799AbZLGNIO (ORCPT ); Mon, 7 Dec 2009 08:08:14 -0500 To: Alan Cox CC: miklos@szeredi.hu, luto@mit.edu, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-reply-to: <20091207130339.620b904b@lxorguk.ukuu.org.uk> (message from Alan Cox on Mon, 7 Dec 2009 13:03:39 +0000) Subject: Re: [PATCH v3] vfs: new O_NODE open flag References: <20091202191549.1dbffa2e@lxorguk.ukuu.org.uk> <20091202204828.4fa0c108@lxorguk.ukuu.org.uk> <4B1A7159.3070101@mit.edu> <20091205202838.3456b6fc@lxorguk.ukuu.org.uk> <20091205231304.03a4af61@lxorguk.ukuu.org.uk> <20091207122346.6d18a8e1@lxorguk.ukuu.org.uk> <20091207130339.620b904b@lxorguk.ukuu.org.uk> Message-Id: From: Miklos Szeredi Date: Mon, 07 Dec 2009 14:08:10 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 24 On Mon, 7 Dec 2009, Alan Cox wrote: > > In other words, revoking file handles is not enough, we really need to > > revoke the _inode_. And if we do that then O_NODE handles are > > perfectly harmless. > > If you have revoke() you are half way there, you also the need to make > sure any user cases are updated and well established before you change > anything under them. It's not good adding a kernel feature which makes an > old udev version insecure. It doesn't, see example with hard link two mails up. Alan, you are just ignoring facts and trying to push revoke(2) which in fact doesn't have much to do with this issue. revoke(2) is about *open devices*, O_NODE doesn't produce an open device. Don't you understand that? Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/