Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935315AbZLGQWO (ORCPT ); Mon, 7 Dec 2009 11:22:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934757AbZLGQWN (ORCPT ); Mon, 7 Dec 2009 11:22:13 -0500 Received: from mgw2.diku.dk ([130.225.96.92]:42816 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932496AbZLGQWL (ORCPT ); Mon, 7 Dec 2009 11:22:11 -0500 Date: Mon, 7 Dec 2009 17:22:16 +0100 (CET) From: Julia Lawall To: "Tung, Chien Tin" Cc: "Latif, Faisal" , Roland Dreier , "Hefty, Sean" , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: RE: [PATCH 3/5] drivers/infiniband: correct size computation In-Reply-To: <603F8A3875DCE940BA37B49D0A6EA0AE3CE36BF4@azsmsx501.amr.corp.intel.com> Message-ID: References: <603F8A3875DCE940BA37B49D0A6EA0AE3CE36BF4@azsmsx501.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 27 On Mon, 7 Dec 2009, Tung, Chien Tin wrote: > Thanks for pointing out the bug. > > > /* Remap the PCI registers in adapter BAR0 to kernel VA space */ > >- mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0), sizeof(mmio_regs)); > >+ mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0), > >+ sizeof(*mmio_regs)); > > if (mmio_regs == NULL) { > > printk(KERN_ERR PFX "Unable to remap BAR0\n"); > > ret = -EIO; > > mmio_regs is initialized to NULL at the top of the function so > *mmio_regs wouldn't be a good idea. Instead of sizeof(*mmio_regs) use > pci_resource_len(pcidev, BAR_0). If you can recreate the patch with > this change I will ack it. When you say that it isn't a good idea, do you mean that the result is wrong, or that it looks odd? I didn't think sizeof looked at the value, but only at the type? julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/