Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965385AbZLHBvo (ORCPT ); Mon, 7 Dec 2009 20:51:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935761AbZLHBvn (ORCPT ); Mon, 7 Dec 2009 20:51:43 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:50380 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935746AbZLHBvm (ORCPT ); Mon, 7 Dec 2009 20:51:42 -0500 Date: Tue, 8 Dec 2009 01:51:48 +0000 From: Al Viro To: Emese Revfy Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org Subject: Re: [PATCH 28/31] Constify struct super_operations for 2.6.32 v1 Message-ID: <20091208015148.GK14381@ZenIV.linux.org.uk> References: <4B1BBE71.70305@gmail.com> <4B1D988E.2000305@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B1D988E.2000305@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 14 On Tue, Dec 08, 2009 at 01:06:38AM +0100, Emese Revfy wrote: > DEBUG_RODATA catches the unwanted write attempt at runtime whereas > my patch will catch it at compile time. I think it's better to detect > an error as early as possible. Not when the price is readability. Moreover, you *still* are not covering the real policy - these suckers should be statically allocated, not just never modified. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/