Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753362AbZLHHJU (ORCPT ); Tue, 8 Dec 2009 02:09:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752506AbZLHHJS (ORCPT ); Tue, 8 Dec 2009 02:09:18 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36487 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752002AbZLHHJR (ORCPT ); Tue, 8 Dec 2009 02:09:17 -0500 Date: Tue, 8 Dec 2009 08:09:15 +0100 From: Pavel Machek To: Wu Zhangjin Cc: Ralf Baechle , akpm@linux-foundation.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , "Rafael J . Wysocki" , zhangfx@lemote.com, linux-laptop@vger.kernel.org, Stephen Rothwell Subject: Re: [PATCH v8 5/8] Loongson: YeeLoong: add hardware monitoring driver Message-ID: <20091208070915.GC12264@elf.ucw.cz> References: <20091206084717.GD2766@ucw.cz> <1260147298.3126.2.camel@falcon.domain.org> <20091207080446.GB23088@elf.ucw.cz> <1260178870.9092.34.camel@falcon.domain.org> <20091207094909.GD23088@elf.ucw.cz> <1260183663.9092.51.camel@falcon.domain.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1260183663.9092.51.camel@falcon.domain.org> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 990 Lines: 25 > > > > That's certainly better. But... why not return signed value? Current > > > > flowing from the battery is certainly very different from current > > > > flowing into it... > > > > > > You are totally right ;) > > > > > > Just test it, when flowing from the battery, the value is negative, and > > > when flowing into the battery, the value is positive, so, no abs() > > > needed. thanks! > > > > Make it return -value, then. I believe other code uses >0 values for > > discharge. > > Done, but any document/standard about it? Not sure, feel free to patch the documentation, too :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/