Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936334AbZLHRTa (ORCPT ); Tue, 8 Dec 2009 12:19:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965000AbZLHRTX (ORCPT ); Tue, 8 Dec 2009 12:19:23 -0500 Received: from cantor.suse.de ([195.135.220.2]:44080 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936327AbZLHRTW (ORCPT ); Tue, 8 Dec 2009 12:19:22 -0500 Date: Tue, 08 Dec 2009 18:19:28 +0100 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: lkml , torvalds , Mauro Carvalho Chehab , Krzysztof Helt Subject: Re: [PATCH] radio/sound/miro: fix build, cleanup depends/selects In-Reply-To: <20091208091307.7bff5964.randy.dunlap@oracle.com> References: <20091208091307.7bff5964.randy.dunlap@oracle.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1802 Lines: 43 At Tue, 8 Dec 2009 09:13:07 -0800, Randy Dunlap wrote: > > From: Randy Dunlap > > miropcm20 uses ALSA (snd_) interfaces from the SND_MIRO > driver, so it should depend on SND. > (selecting SND_MIRO when CONFIG_SND is not enabled is a > problem.) > > drivers/built-in.o: In function `vidioc_s_ctrl': > radio-miropcm20.c:(.text+0x227499): undefined reference to `snd_aci_cmd' > drivers/built-in.o: In function `vidioc_s_frequency': > radio-miropcm20.c:(.text+0x227574): undefined reference to `snd_aci_cmd' > radio-miropcm20.c:(.text+0x227588): undefined reference to `snd_aci_cmd' > drivers/built-in.o: In function `pcm20_init': > radio-miropcm20.c:(.init.text+0x2a784): undefined reference to `snd_aci_get_aci' > > miropcm20 selects SND_MIRO but SND_ISA may be not enabled, so > also select SND_ISA so that the snd-miro driver will be built. > Otherwise there are missing symbols: > > ERROR: "snd_opl4_create" [sound/isa/opti9xx/snd-miro.ko] undefined! > ERROR: "snd_wss_pcm" [sound/isa/opti9xx/snd-miro.ko] undefined! > ERROR: "snd_wss_timer" [sound/isa/opti9xx/snd-miro.ko] undefined! > ERROR: "snd_wss_create" [sound/isa/opti9xx/snd-miro.ko] undefined! > ERROR: "snd_wss_mixer" [sound/isa/opti9xx/snd-miro.ko] undefined! > > Signed-off-by: Randy Dunlap > Acked-by: Mauro Carvalho Chehab > Cc: Krzysztof Helt > Cc: Takashi Iwai Thanks, applied to sound git tree now. I'm going to send the second pull request tomorrow or so. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/