Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965796AbZLHTGm (ORCPT ); Tue, 8 Dec 2009 14:06:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965787AbZLHTGg (ORCPT ); Tue, 8 Dec 2009 14:06:36 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44036 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965724AbZLHTGf (ORCPT ); Tue, 8 Dec 2009 14:06:35 -0500 Date: Tue, 8 Dec 2009 11:05:39 -0800 From: Stephen Hemminger To: Mathieu Desnoyers Cc: "David S. Miller" , Robert Olsson , Jens Laas , Hans Liss , "Paul E. McKenney" , Patrick McHardy , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fib-trie: code cleanup Message-ID: <20091208110539.2b46e64b@nehalam> In-Reply-To: <20091208184839.GA31383@Krystal> References: <20091208184839.GA31383@Krystal> Organization: Linux Foundation X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.3; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 505 Lines: 14 On Tue, 8 Dec 2009 13:48:39 -0500 Mathieu Desnoyers wrote: > - I moved static const that were hidden in the middle of the file to defines on > top. Keep them as static const, makeing them #define's doesn't help anything -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/