Date: Tue, 8 Dec 2009 11:29:10 -0800
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: "David S. Miller" <davem@davemloft.net>,
       Robert Olsson <robert.olsson@its.uu.se>,
       Jens Laas <jens.laas@data.slu.se>, Hans Liss <hans.liss@its.uu.se>,
       "Paul E. McKenney" <paulmck@us.ibm.com>,
       Patrick McHardy <kaber@trash.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fib-trie: code cleanup
Message-ID: <20091208112910.7a1a3d43@nehalam>
In-Reply-To: <20091208192006.GC1653@Krystal>
References: <20091208184839.GA31383@Krystal>
	<20091208110642.1dbb53cd@nehalam>
	<20091208192006.GC1653@Krystal>
Organization: Linux Foundation
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1289
Lines: 48

On Tue, 8 Dec 2009 14:20:06 -0500
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

> * Stephen Hemminger (shemminger@linux-foundation.org) wrote:
> > On Tue, 8 Dec 2009 13:48:39 -0500
> > Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> > 
> > > -	while ( (tb_node = rcu_dereference(tb->tb_hlist.next)) ) {
> > > +	while ((tb_node = rcu_dereference(tb->tb_hlist.next))) {
> > >  
> > 
> > This is clearer before with the added whitespace, ignore checkpatch natterings.
> 
> OK
> 
> Then we should do the same for all assignment within while() :
> 
> static void tnode_free_flush(void)
> {
>         struct tnode *tn;
> 
>         while ( (tn = tnode_free_head) ) {
> 
> ...
> 
> static struct leaf *leaf_walk_rcu(struct tnode *p, struct node *c)
> {
> .....
>                /* Node empty, walk back up to parent */
>                 c = (struct node *) p;
>         } while ( (p = node_parent_rcu(c)) != NULL);
> 
>         return NULL; /* Root of trie */
> }
> 
> 
> > 
> > -- 
> 

Yes, consistency on this makes sense.

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/