Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965749AbZLHVen (ORCPT ); Tue, 8 Dec 2009 16:34:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965711AbZLHVem (ORCPT ); Tue, 8 Dec 2009 16:34:42 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42603 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756284AbZLHVel (ORCPT ); Tue, 8 Dec 2009 16:34:41 -0500 Date: Tue, 8 Dec 2009 13:34:02 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Ingo Molnar cc: linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , Andrew Morton Subject: Re: [GIT PULL] x86/paravirt for v2.6.33 In-Reply-To: <20091203210913.GA24351@elte.hu> Message-ID: References: <20091203210913.GA24351@elte.hu> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 33 On Thu, 3 Dec 2009, Ingo Molnar wrote: > > Please pull the latest x86-paravirt-for-linus git tree from: > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-paravirt-for-linus I _really_ don't like this: > -long sys_iopl(struct pt_regs *regs) > +asmlinkage long sys_iopl(unsigned int level) > { > - unsigned int level = regs->bx; > struct thread_struct *t = ¤t->thread; > + struct pt_regs *regs = task_pt_regs(current); I do _not_ want to add any more task_pt_regs() crap, please. Why? It's wrong for at least vm86 mode (and from kernel system calls). Maybe we can't get into system calls from vm86 mode, and the kernel hopefully doesn't do those things anyway, but the point is, you chose the wrong way to go. The old version that actually passed the stack frame was better. Why pick the inferior version? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/