Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966753AbZLHWT2 (ORCPT ); Tue, 8 Dec 2009 17:19:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966719AbZLHWTY (ORCPT ); Tue, 8 Dec 2009 17:19:24 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53538 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965718AbZLHWTX (ORCPT ); Tue, 8 Dec 2009 17:19:23 -0500 Date: Tue, 8 Dec 2009 14:18:57 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Alan Stern cc: "Rafael J. Wysocki" , Zhang Rui , LKML , ACPI Devel Maling List , pm list Subject: Re: Async resume patch (was: Re: [GIT PULL] PM updates for 2.6.33) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 23 On Tue, 8 Dec 2009, Alan Stern wrote: > > And likewise in try_wait_for_completion(). It looks like a bug. Maybe > these routines were not intended to be called with interrupts disabled, > but that requirement doesn't seem to be documented. And it isn't a > natural requirement anyway. 'complete()' is supposed to be callable from interrupts, but the waiting ones aren't. But 'complete()' is all you should need to call from interrupts, so that's fine. So I think completions should work, if done right. That whole "make the parent wait for all the children to complete" is fine in that sense. And I'll happily take such an approach if my rwlock thing doesn't work. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/