Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757264AbZLITDL (ORCPT ); Wed, 9 Dec 2009 14:03:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756912AbZLITDI (ORCPT ); Wed, 9 Dec 2009 14:03:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29993 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756686AbZLITDH (ORCPT ); Wed, 9 Dec 2009 14:03:07 -0500 From: Jeff Moyer To: Vivek Goyal Cc: jens.axboe@oracle.com, linux-kernel@vger.kernel.org, guijianfeng@cn.fujitsu.com Subject: Re: [PATCH 1/2] cfq-iosched: Get rid of cfqq wait_busy_done flag References: <1260312778-4725-1-git-send-email-vgoyal@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Wed, 09 Dec 2009 14:03:06 -0500 In-Reply-To: <1260312778-4725-1-git-send-email-vgoyal@redhat.com> (Vivek Goyal's message of "Tue, 8 Dec 2009 17:52:57 -0500") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 657 Lines: 14 Vivek Goyal writes: > o Get rid of wait_busy_done flag. This flag only tells we were doing wait > busy on a queue and that queue got request so expire it. That information > can easily be obtained by (cfq_cfqq_wait_busy() && queue_is_not_empty). So > remove this flag and keep code simple. > > Signed-off-by: Vivek Goyal Reviewed-by: Jeff Moyer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/