Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757244AbZLITJW (ORCPT ); Wed, 9 Dec 2009 14:09:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757030AbZLITJU (ORCPT ); Wed, 9 Dec 2009 14:09:20 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41770 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757023AbZLITJU (ORCPT ); Wed, 9 Dec 2009 14:09:20 -0500 Date: Wed, 9 Dec 2009 11:08:41 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: "H. Peter Anvin" cc: Jeremy Fitzhardinge , Ingo Molnar , linux-kernel@vger.kernel.org, Thomas Gleixner , Andrew Morton Subject: Re: [GIT PULL] x86/paravirt for v2.6.33 In-Reply-To: <4B1FF27E.8030701@zytor.com> Message-ID: References: <20091203210913.GA24351@elte.hu> <20091209073632.GD8187@elte.hu> <4B1FED0D.7060003@goop.org> <4B1FF27E.8030701@zytor.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 25 On Wed, 9 Dec 2009, H. Peter Anvin wrote: > > The second argument is in %edx, but unlike 64 bits, it is not loaded > into that register a priory ("asmlinkage" means arguments are on the stack.) Oh, I missed the fact that we don't actually use asmlinkage on sys_iopl() at all on x86-32 for this very reason. And on x86-64, I think asmlinkage is a no-op, so that's ok - we should just make the prototype be long sys_iopl(long level, struct pt_regs *regs); and your fancier macros. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/