Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755739AbZLIViO (ORCPT ); Wed, 9 Dec 2009 16:38:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754242AbZLIViK (ORCPT ); Wed, 9 Dec 2009 16:38:10 -0500 Received: from waste.org ([173.11.57.241]:39989 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753735AbZLIViK (ORCPT ); Wed, 9 Dec 2009 16:38:10 -0500 Subject: Re: [PATCH] [19/31] mm: export stable page flags From: Matt Mackall To: Wu Fengguang Cc: Andi Kleen , "npiggin@suse.de" , "cl@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" In-Reply-To: <20091209020042.GA7751@localhost> References: <200912081016.198135742@firstfloor.org> <20091208211635.7965AB151F@basil.firstfloor.org> <1260311251.31323.129.camel@calx> <20091209020042.GA7751@localhost> Content-Type: text/plain; charset="UTF-8" Date: Wed, 09 Dec 2009 15:38:08 -0600 Message-ID: <1260394688.24459.991.camel@calx> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1619 Lines: 43 On Wed, 2009-12-09 at 10:00 +0800, Wu Fengguang wrote: > On Wed, Dec 09, 2009 at 06:27:31AM +0800, Matt Mackall wrote: > > On Tue, 2009-12-08 at 22:16 +0100, Andi Kleen wrote: > > > From: Wu Fengguang > > > > > > Rename get_uflags() to stable_page_flags() and make it a global function > > > for use in the hwpoison page flags filter, which need to compare user > > > page flags with the value provided by user space. > > > > > > Also move KPF_* to kernel-page-flags.h for use by user space tools. > > > > > > CC: Matt Mackall > > > CC: Nick Piggin > > > CC: Christoph Lameter > > > CC: Andi Kleen > > > Signed-off-by: Wu Fengguang > > > Signed-off-by: Andi Kleen > > > > Acked-by: Matt Mackall > > Andi and Matt, > > Sorry the stable_page_flags() will be undefined on > !CONFIG_PROC_PAGE_MONITOR (it is almost always on, > except for some embedded systems). > > Currently the easy solution is to add a Kconfig dependency to > CONFIG_PROC_PAGE_MONITOR. When there comes more users (ie. some > ftrace event), we can then always compile in stable_page_flags(). No objections. Acked-by: Matt Mackall -- http://selenic.com : development and support for Mercurial and Linux -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/