Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758939AbZLJAHu (ORCPT ); Wed, 9 Dec 2009 19:07:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758864AbZLJAHp (ORCPT ); Wed, 9 Dec 2009 19:07:45 -0500 Received: from terminus.zytor.com ([198.137.202.10]:38963 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758856AbZLJAHo (ORCPT ); Wed, 9 Dec 2009 19:07:44 -0500 Message-ID: <4B203B48.3070906@zytor.com> Date: Wed, 09 Dec 2009 16:05:28 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4 MIME-Version: 1.0 To: Brian Gerst CC: Ingo Molnar , x86@kernel.org, torvalds@linux-foundation.org, jeremy@goop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] x86, 32-bit: Add new pt_regs stubs References: <1260403316-5679-1-git-send-email-brgerst@gmail.com> <1260403316-5679-2-git-send-email-brgerst@gmail.com> In-Reply-To: <1260403316-5679-2-git-send-email-brgerst@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 23 On 12/09/2009 04:01 PM, Brian Gerst wrote: > Add new stubs which add the pt_regs pointer as the last arg, matching > 64-bit. This will allow these syscalls to be easily merged. > > Signed-off-by: Brian Gerst > +ptregs_##name: \ > + leal 4(%esp),%edx; \ > + movl PT_EBX(%edx),%eax; \ > + jmp sys_##name; You're introducing a completely unnecessary pipeline serialization here. Instead do: movl (PT_EBX+4)(%esp),%eax; ... making the statements independent and therefore executable in parallel. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/