Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761007AbZLJQ1k (ORCPT ); Thu, 10 Dec 2009 11:27:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760964AbZLJQ1h (ORCPT ); Thu, 10 Dec 2009 11:27:37 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:50823 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760963AbZLJQ1g (ORCPT ); Thu, 10 Dec 2009 11:27:36 -0500 Date: Thu, 10 Dec 2009 17:27:34 +0100 From: Pavel Machek To: Arve Hj?nnev?g Cc: Russell King - ARM Linux , kernel list , linux-arm-kernel , Brian Swetland , Daniel Walker , Iliyan Malchev Subject: Re: GPIO support for HTC Dream Message-ID: <20091210162734.GH19454@elf.ucw.cz> References: <20091208102842.GH12264@elf.ucw.cz> <20091208224550.GA26915@n2100.arm.linux.org.uk> <20091209113739.GC22752@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2320 Lines: 57 On Wed 2009-12-09 03:42:43, Arve Hj?nnev?g wrote: > On Wed, Dec 9, 2009 at 3:37 AM, Pavel Machek wrote: > > On Tue 2009-12-08 16:39:09, Arve Hj?nnev?g wrote: > >> On Tue, Dec 8, 2009 at 2:45 PM, Russell King - ARM Linux > >> wrote: > >> > On Tue, Dec 08, 2009 at 11:28:43AM +0100, Pavel Machek wrote: > >> >> Add GPIO support for HTC Dream. > >> >> > >> >> Signed-off-by: Pavel Machek > >> >> > >> >> diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig > >> >> index f780086..774c50e 100644 > >> >> --- a/arch/arm/mach-msm/Kconfig > >> >> +++ b/arch/arm/mach-msm/Kconfig > >> >> @@ -40,4 +40,8 @@ config MACH_TROUT > >> >> ? ? ? help > >> >> ? ? ? ? Support for the HTC Dream, T-Mobile G1, Android ADP1 devices. > >> >> > >> >> +config GENERIC_GPIO > >> >> + ? ? bool > >> >> + ? ? default y > >> > > >> > Please arrange for this to be handled just like every other ARM > >> > platform via a 'select' statement - eg: > >> > > >> > config ARCH_AT91 > >> > ? ? ? ?bool "Atmel AT91" > >> > ? ? ? ?select GENERIC_GPIO > >> > ? ? ? ?select ARCH_REQUIRE_GPIOLIB > >> > ? ? ? ?select HAVE_CLK > >> > > >> > It is not nice to have multiple definitions of the same symbol scattered > >> > throughout the Kconfig files. > >> > > >> > >> Why did this code get pulled into the dream gpio code? The original > >> change that adds msm gpio support already selects GENERIC_GPIO > >> (http://android.git.kernel.org/?p=kernel/msm.git;a=commit;h=5ae9f4403530a5782478c35d29753081750c4188). > >> Since you copied half of the files from that change anyway, it would > >> be better to just include that change in you patch set. > > > > I'm not sure how to do that with git without pulling all the changes > > before that one, too :-(. > > git cherry-pick Ok, I'll try to remember that. But I do not push patches using git, so I'm not sure how much difference it would make. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/