Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761711AbZLJVT5 (ORCPT ); Thu, 10 Dec 2009 16:19:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761639AbZLJVT4 (ORCPT ); Thu, 10 Dec 2009 16:19:56 -0500 Received: from lon1-post-1.mail.demon.net ([195.173.77.148]:57263 "EHLO lon1-post-1.mail.demon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754429AbZLJVTz (ORCPT ); Thu, 10 Dec 2009 16:19:55 -0500 Message-ID: <4B21656B.1090607@lougher.demon.co.uk> Date: Thu, 10 Dec 2009 21:17:31 +0000 From: Phillip Lougher User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Geert Uytterhoeven CC: dedekind1@gmail.com, Andrew Morton , linux-embedded@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, phillip.lougher@gmail.com, Tim Bird , Geert Uytterhoeven , Felix Fietkau Subject: Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file References: <20091207145705.cd30cae8.akpm@linux-foundation.org> <4B1ED122.3040309@lougher.demon.co.uk> <1260352852.19669.1253.camel@localhost> <4B2042FA.8080406@lougher.demon.co.uk> <10f740e80912100201l6d83588evff46e95ec96d0aed@mail.gmail.com> In-Reply-To: <10f740e80912100201l6d83588evff46e95ec96d0aed@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 26 Geert Uytterhoeven wrote: > >> Yes I did consider using the cryptoapi, but this doesn't have support for >> lzma in mainline. > > IIRC, Felix Fietkau added support for that for OpenWRT... > Yes, but it isn't in mainline, and OpenWRT don't appear to have tried to submit it. IMHO the major problem with their patch is it uses a second private copy of lzma, rather than being a wrapper around the pre-existing lzma implementation. I don't think it's going to be easy to get a second lzma implementation accepted into mainline, when it took so long to get one accepted. I have nothing against the cryptoapi, but it doesn't seem likely to be getting lzma support anytime soon. As I previously said my aim is to use the pre-existing lzma implementation. Unless it is stupendously bad (which it isn't), that seems to be the quickest, easiest and best way to get lzma support into Squashfs. Phillip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/