From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: lwoodman@redhat.com
Subject: Re: [RFC][PATCH v2  4/8] Replace page_referenced() with wipe_page_reference()
Cc: kosaki.motohiro@jp.fujitsu.com, LKML <linux-kernel@vger.kernel.org>,
       linux-mm <linux-mm@kvack.org>, Rik van Riel <riel@redhat.com>,
       Andrea Arcangeli <aarcange@redhat.com>
In-Reply-To: <4B20EF88.7050402@redhat.com>
References: <20091210163123.255C.A69D9226@jp.fujitsu.com> <4B20EF88.7050402@redhat.com>
Message-Id: <20091211082410.257D.A69D9226@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Fri, 11 Dec 2009 08:46:25 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1423
Lines: 50

> KOSAKI Motohiro wrote:
> > @@ -578,7 +577,9 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> >
> > +		struct page_reference_context refctx = {
> > +			.is_page_locked = 1,
> >
> >   *
> > @@ -1289,7 +1291,6 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
> >
> > +		struct page_reference_context refctx = {
> > +			.is_page_locked = 0,
> > +		};
> > +
> >   
> are these whole structs properly initialized on the kernel stack?

Yes. C spec says

3.5.7 Initialization

Syntax

          initializer:
                  assignment-expression
                  {  initializer-list } 
                  {  initializer-list , }

          initializer-list:
                  initializer
                  initializer-list ,  initializer
(snip)

   If there are fewer initializers in a list than there are members of
an aggregate, the remainder of the aggregate shall be initialized
implicitly the same as objects that have static storage duration.

Referenced to
  Draft ANSI C Standard (ANSI X3J11/88-090) (May 13, 1988) http://flash-gordon.me.uk/ansi.c.txt


Probably, google "{0}" help your understand to initializer in C.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/