Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762189AbZLKBod (ORCPT ); Thu, 10 Dec 2009 20:44:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762122AbZLKBob (ORCPT ); Thu, 10 Dec 2009 20:44:31 -0500 Received: from exprod6og112.obsmtp.com ([64.18.1.29]:53742 "EHLO exprod6og112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758085AbZLKBo1 convert rfc822-to-8bit (ORCPT ); Thu, 10 Dec 2009 20:44:27 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: [PATCH] dw_dmac.c: remove unnecessary memset() and use resource_size() Date: Thu, 10 Dec 2009 20:44:32 -0500 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] dw_dmac.c: remove unnecessary memset() and use resource_size() Thread-Index: Acp6A3yWhWAW4PpCRLWLI1+/JddRQw== From: "H Hartley Sweeten" To: "kernel list" Cc: X-OriginalArrivalTime: 11 Dec 2009 01:44:34.0076 (UTC) FILETIME=[7D6545C0:01CA7A03] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1517 Lines: 47 The memset() is unnecessary since kzalloc already zero's the memory. The platform resource is properly defined so use resource_size() instead of the magic number DW_REGLEN for the ioremap() and {request/release}_mem_region(). Signed-off-by: H Hartley Sweeten Cc: Haavard Skinnemoen --- diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index 2eea823..97ea99a 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c @@ -1265,14 +1265,13 @@ static int __init dw_probe(struct platform_device *pdev) if (!dw) return -ENOMEM; - if (!request_mem_region(io->start, DW_REGLEN, pdev->dev.driver->name)) { + if (!request_mem_region(io->start, resource_size(io), + pdev->dev.driver->name)) { err = -EBUSY; goto err_kfree; } - memset(dw, 0, sizeof *dw); - - dw->regs = ioremap(io->start, DW_REGLEN); + dw->regs = ioremap(io->start, resource_size(io)); if (!dw->regs) { err = -ENOMEM; goto err_release_r; @@ -1392,7 +1391,7 @@ static int __exit dw_remove(struct platform_device *pdev) dw->regs = NULL; io = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(io->start, DW_REGLEN); + release_mem_region(io->start, resource_size(io)); kfree(dw); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/