Date: Fri, 11 Dec 2009 11:38:48 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Jamie Iles <jamie.iles@picochip.com>
Cc: linux-kernel@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
       Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] perf tools: allow building for ARM
Message-ID: <20091211103848.GA9947@elte.hu>
References: <1260523260-15694-1-git-send-email-jamie.iles@picochip.com>
 <20091211102316.GB16882@elte.hu>
 <20091211103030.GC4164@wear.picochip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091211103030.GC4164@wear.picochip.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1948
Lines: 42


* Jamie Iles <jamie.iles@picochip.com> wrote:

> On Fri, Dec 11, 2009 at 11:23:16AM +0100, Ingo Molnar wrote:
> > cpu_relax() looks fine, but rmb() seems not to match the one that can be 
> > found in arch/arm/:
> > 
> > arch/arm/include/asm/system.h:#define rmb()		dmb()
> > arch/arm/include/asm/system.h:#define rmb()	do { if (arch_is_coherent()) dmb(); else barrier(); } while (0)
> > arch/arm/include/asm/system.h:#define smp_rmb()	rmb()
> > 
> > arch/arm/include/asm/system.h:#define dmb() __asm__ __volatile__ ("dmb" : : : "memory")
> > arch/arm/include/asm/system.h:#define dmb() __asm__ __volatile__ ("mcr p15, 0, %0, c7, c10, 5" \
> > arch/arm/include/asm/system.h:#define dmb() __asm__ __volatile__ ("" : : : "memory")
> > arch/arm/include/asm/system.h:#define dmb() __asm__ __volatile__ ("" : : : "memory")
>
> The implementation of the barriers depend on the CPU arch revision 
> which is defined in the kernel config. As the perf tools don't use the 
> kernel config, we don't know here what arch revision we're building 
> for. Perhaps we need a LINUX_ARM_ARCH parameter when building for ARM 
> so we can pick the correct one.

rmb() is used in two places in perf:

 tools/perf/builtin-record.c:    rmb();
 tools/perf/builtin-top.c:       rmb();

to interact with the shared kernel/user ring-buffer. Getting a barrier 
wrong there may cause hickups in recording.

Could you tell me a bit more about this ARM instruction - is the 'DMB' 
instruction used on all SMP ARM cores? Can it be used unconditionally, 
or is the instruction undefined on certain versions? To get the ball 
rolling we could use it unconditionally in the initial patch, but this 
needs to be solved i suspect.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/