DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=LiiSTg9mJ0zCiZP/Bh6JZ+1aJO6YMLQj+mn9T+VrktjrLxaORmuhIaUSLBPGCJraMH
         RdH5G0syEZNBTpgAuzuNrS4e34ycnp0WWLf7SuRc09AVvYn3Pe5reUNN3+p1kbCZE0WI
         rKpFNGGurDPl5Pv8uqSxd6KzIdhp5q20sQmys=
Date: Fri, 11 Dec 2009 12:04:47 +0100
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Wenji Huang <wenji.huang@oracle.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Return value of print_graph_prologue
Message-ID: <20091211110444.GA5244@nowhere>
References: <4B221B0F.6040107@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B221B0F.6040107@oracle.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 927
Lines: 33

On Fri, Dec 11, 2009 at 06:12:31PM +0800, Wenji Huang wrote:
> Hi,
>
> I got confused about the return value of print_graph_prologue. See:
>
> 805         /* Latency format */
> 806         if (trace_flags & TRACE_ITER_LATENCY_FMT) {
> 807                 ret = print_graph_lat_fmt(s, ent);
> 808                 if (ret == TRACE_TYPE_PARTIAL_LINE)
> 809                         return TRACE_TYPE_PARTIAL_LINE;
> 810         }
> 811
> 812         return 0;
> 813 }
>
> But we have defined TRACE_TYPE_PARTIAL_LINE = 0. So there's
> no difference between success and failure?
>
> Should it be TRACE_TYPE_HANDLED ?
>
> Regards,
> Wenji


Oh, good catch, I'm preparing a fix.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/