Subject: Re: [PATCH]tracing: Fix inaccurate function definition in
 trace_events_filter.c
From: Steven Rostedt <rostedt@goodmis.org>
Reply-To: rostedt@goodmis.org
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Wenji Huang <wenji.huang@oracle.com>, linux-kernel@vger.kernel.org,
       fweisbec@gmail.com, tzanussi@gmail.com
In-Reply-To: <4B21FF84.3010509@cn.fujitsu.com>
References: <1260518338-16034-1-git-send-email-wenji.huang@oracle.com>
	 <4B21FF84.3010509@cn.fujitsu.com>
Content-Type: text/plain; charset="ISO-8859-15"
Organization: Kihon Technologies Inc.
Date: Fri, 11 Dec 2009 09:39:24 -0500
Message-ID: <1260542364.2146.351.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 788
Lines: 24

On Fri, 2009-12-11 at 16:15 +0800, Li Zefan wrote:
> Wenji Huang wrote:
> > Use strcmp instead of strncmp to do full match.
> > 
> 
> It's intended to use strncmp instead of strcmp..
> 
> field(char, name, size) will be treated as a STATIC_STRING by
> filter code. But this field isn't necessarily a string, it
> can be an array of chars, which may not be ended with '\0'.
> So in this case, we can't use strcmp.
> 
> So do you really see incorrect filter results?

Yeah, I agree that this should be strncmp. Have you seen errors?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/