Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762833AbZLKXu1 (ORCPT ); Fri, 11 Dec 2009 18:50:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761661AbZLKXuU (ORCPT ); Fri, 11 Dec 2009 18:50:20 -0500 Received: from exprod6ob113.obsmtp.com ([64.18.1.30]:57443 "EHLO psmtp.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761650AbZLKXuT convert rfc822-to-8bit (ORCPT ); Fri, 11 Dec 2009 18:50:19 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: RE: GPIO support for HTC Dream Date: Fri, 11 Dec 2009 18:50:25 -0500 Message-ID: In-Reply-To: <20091211232838.GE12628@n2100.arm.linux.org.uk> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: GPIO support for HTC Dream Thread-Index: Acp6ub5I2J438JcTTrujzNk3VafjbwAAaCtQ References: <20091208102842.GH12264@elf.ucw.cz> <4B1EB57D.6070408@bluewatersys.com> <20091208214658.GC4164@elf.ucw.cz> <4B1ECEEE.3000209@bluewatersys.com> <4B203575.6050407@bluewatersys.com> <20091210172458.GJ19454@elf.ucw.cz> <4B2150B7.3040207@bluewatersys.com> <20091211221015.GB24456@elf.ucw.cz> <20091211232838.GE12628@n2100.arm.linux.org.uk> From: "H Hartley Sweeten" To: "Russell King - ARM Linux" , "Pavel Machek" Cc: "Daniel Walker" , "Iliyan Malchev" , "Brian Swetland" , "kernel list" , "Ryan Mallon" , "Arve Hj?nnev?g" , "linux-arm-kernel" X-OriginalArrivalTime: 11 Dec 2009 23:50:23.0722 (UTC) FILETIME=[B4ADF4A0:01CA7ABC] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 46 On Friday, December 11, 2009 4:29 PM, Russell King wrote: > On Fri, Dec 11, 2009 at 11:10:15PM +0100, Pavel Machek wrote: >> +#include > ... >> +#include > ... >> +#include > > Emm, this is getting really silly. > > include/linux/gpio.h: > > #ifdef CONFIG_GENERIC_GPIO > #include > #else > ... > #endif > > arch/arm/include/asm/gpio.h: > > #include > > There really is no point in including mach/gpio.h nor asm/gpio.h when > linux/gpio.h will do. I'm retiscent to add #warnings or #errors into > these files, but it seems that this is such a common thing that it may > be beneficial to do so. Hi Russell, I think you mentioned last year around this time, when the big header move occurred, that you were going to add a guideline for mach/*.h headers to Documentation/arm. Maybe it's time to add that patch and just note that the version of the common headers should be used and that the and header gets pulled in automatically. I think the two big ones that everyone screws up are, and . Regards, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/