Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935118AbZLKXxt (ORCPT ); Fri, 11 Dec 2009 18:53:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934038AbZLKXxp (ORCPT ); Fri, 11 Dec 2009 18:53:45 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:37389 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934014AbZLKXxo (ORCPT ); Fri, 11 Dec 2009 18:53:44 -0500 Date: Fri, 11 Dec 2009 15:53:14 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: "Rafael J. Wysocki" cc: Alan Stern , Zhang Rui , LKML , ACPI Devel Maling List , pm list Subject: Re: Async suspend-resume patch w/ completions (was: Re: Async suspend-resume patch w/ rwsems) In-Reply-To: <200912120048.46180.rjw@sisk.pl> Message-ID: References: <200912112311.08548.rjw@sisk.pl> <200912120048.46180.rjw@sisk.pl> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 22 On Sat, 12 Dec 2009, Rafael J. Wysocki wrote: > > Below is a patch I've just tested, but there's a lockdep problem in it I don't > know how to solve. Namely, lockdep is apparently unhappy with us not releasing > the lock taken in device_suspend() and it complains we take it twice in a row > (which we do, but for another device). I need to use down_read_non_owner() > to make it shut up and then I also need to use up_read_non_owner() in > __device_suspend(), Ok, that I admit is actually a problem. Ok, ok, I'll accept that completion() version, even though I think it's inferior. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/