Subject: Re: hwrng: virtio - Rename driver object to remove section
 mismatch warning
From: Matt Mackall <mpm@selenic.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
       Herbert Xu <herbert@gondor.apana.org.au>,
       Rusty Russell <rusty@rustcorp.com.au>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       samr@ravnborg.org
In-Reply-To: <20091212002148.GA9586@merkur.ravnborg.org>
References: <20091211153658.GA1207@gondor.apana.org.au>
	 <1260559557.24459.1320.camel@calx>
	 <20091211120849.012c43d8.randy.dunlap@oracle.com>
	 <20091212002148.GA9586@merkur.ravnborg.org>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 11 Dec 2009 18:33:17 -0600
Message-ID: <1260577997.24459.1405.camel@calx>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1230
Lines: 33

On Sat, 2009-12-12 at 01:21 +0100, Sam Ravnborg wrote:
> On Fri, Dec 11, 2009 at 12:08:49PM -0800, Randy Dunlap wrote:
> > On Fri, 11 Dec 2009 13:25:57 -0600 Matt Mackall wrote:
> > 
> > > On Fri, 2009-12-11 at 23:36 +0800, Herbert Xu wrote:
> > > > Hi:
> > > > 
> > > > Finally found the cause of the section mismatch warning in hwrng.
> > > > Apparently in addition to __devexit_p we now have to name the
> > > > variable in a certain way.
> > > 
> > > That's fairly appalling. Any idea why?
> > 
> > (I haven't read the rest of this thread..)
> > 
> > scripts/mod/modpost.c looks for certain variable names to identify
> > variables that can have references to other (non-data) sections.
> > It's mostly explained there.
> 
> Another option is to annotate the relevant variable.

Ok, I guess I knew about the annotations. So I take it the name magic
exists just for convenience or to hit the common cases?

-- 
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/