Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761926AbZLLFze (ORCPT ); Sat, 12 Dec 2009 00:55:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761862AbZLLFzc (ORCPT ); Sat, 12 Dec 2009 00:55:32 -0500 Received: from mail-pw0-f42.google.com ([209.85.160.42]:56025 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761851AbZLLFzW convert rfc822-to-8bit (ORCPT ); Sat, 12 Dec 2009 00:55:22 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 11 Dec 2009 21:55:28 -0800 Message-ID: Subject: Re: [tip:sched/urgent] sched: Set correct normal_prio and prio values in sched_fork() From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, efault@gmx.de, tglx@linutronix.de, pwil3058@bigpond.net.au, mingo@elte.hu Cc: linux-tip-commits@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1370 Lines: 34 On Mon, Oct 5, 2009 at 3:47 AM, tip-bot for Peter Williams wrote: > Commit-ID: ?f83f9ac2632732bd1678150b5a03d152f912fe72 > Gitweb: ? ? http://git.kernel.org/tip/f83f9ac2632732bd1678150b5a03d152f912fe72 > Author: ? ? Peter Williams > AuthorDate: Thu, 24 Sep 2009 06:47:10 +0000 > Committer: ?Ingo Molnar > CommitDate: Mon, 5 Oct 2009 13:42:20 +0200 > > sched: Set correct normal_prio and prio values in sched_fork() > > normal_prio should be updated if policy changes from RT to > SCHED_MORMAL or if static_prio/nice is changed. > > Some paths through sched_fork() ignore this requirement and may > result in normal_prio having an invalid value. > > Fixing this issue allows the call to effective_prio() in > wake_up_new_task() to be removed. > This change causes a lot of threads with a 0 nice value to get a prio value of 140 instead of 120 (at least on my android arm msm build). I don't know if this has any impact on how they are scheduled since the load weight is unaffected, but it at least makes the output of ps more confusing. -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/