Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756529AbZLMBPR (ORCPT ); Sat, 12 Dec 2009 20:15:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932139AbZLMBPB (ORCPT ); Sat, 12 Dec 2009 20:15:01 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:36346 "HELO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932163AbZLMBPA (ORCPT ); Sat, 12 Dec 2009 20:15:00 -0500 Date: Sat, 12 Dec 2009 14:25:23 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Thomas Gleixner cc: Alan Cox , Andrew Morton , Ingo Molnar , Greg KH , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [GIT PATCH] TTY patches for 2.6.33-git In-Reply-To: Message-ID: References: <20091211232805.GA10652@kroah.com> <20091212084611.GA28266@elte.hu> <20091212013927.58d386d1.akpm@linux-foundation.org> <20091212101032.GB25286@elte.hu> <20091212023603.93768833.akpm@linux-foundation.org> <20091212214235.31429790@lxorguk.ukuu.org.uk> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 19 On Sat, 12 Dec 2009, Thomas Gleixner wrote: > > Just patched the following in and it catched your problem nicely. With > your AB/BA fix patch applied everything is fine. Actually, the patch I just suggested might be better. Admittedly the CONFIG_PREEMPT case is the more important one (and the one that will catch more cases), but even without preemptyion the might_sleep() in _lock_kernel() (one underscore) would trigger on the case of somebody doing lock_kernel with local interrupts disabled. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/