Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933822AbZLMBks (ORCPT ); Sat, 12 Dec 2009 20:40:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933622AbZLMBkr (ORCPT ); Sat, 12 Dec 2009 20:40:47 -0500 Received: from gateway-1237.mvista.com ([206.112.117.35]:27692 "HELO imap.sh.mvista.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S933752AbZLMBkq (ORCPT ); Sat, 12 Dec 2009 20:40:46 -0500 Message-ID: <4B241F10.7050706@ru.mvista.com> Date: Sun, 13 Dec 2009 01:54:08 +0300 From: Sergei Shtylyov User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: H Hartley Sweeten Cc: kernel list , linux-ide@vger.kernel.org, David Miller Subject: Re: [PATCH] au1xxx-ide.c: ioremap() returns a void __iomem * References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1300 Lines: 43 Hello. H Hartley Sweeten wrote: > The ioremap return value is an __iomem *, not an integer. Update the > private structure to reflect this. While here, remove the typedef > for _auide_hwif and just use struct auide_hwif instead as recommended > by Documentation/CodingStyle. > > auide_setup_ports() still needs to cast the regbase back to an integer > to correctly setup the io_ports_array. > > Signed-off-by: H Hartley Sweeten > Cc: David Miller > > --- > > diff --git a/Documentation/mips/AU1xxx_IDE.README b/Documentation/mips/AU1xxx_IDE.README > index 8ace35e..37c6c34 100644 > --- a/Documentation/mips/AU1xxx_IDE.README > +++ b/Documentation/mips/AU1xxx_IDE.README > @@ -45,7 +45,7 @@ FILES, CONFIGS AND COMPATABILITY > Two files are introduced: > > a) 'arch/mips/include/asm/mach-au1x00/au1xxx_ide.h' > - containes : struct _auide_hwif > + containes : struct auide_hwif > Contains? Other than that, Acked-by: Sergei Shtylyov MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/