Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573AbZLMLfH (ORCPT ); Sun, 13 Dec 2009 06:35:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752516AbZLMLfG (ORCPT ); Sun, 13 Dec 2009 06:35:06 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:44039 "HELO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1751918AbZLMLfF (ORCPT ); Sun, 13 Dec 2009 06:35:05 -0500 Date: Sun, 13 Dec 2009 11:36:26 +0000 From: Alan Cox To: Ingo Molnar Cc: Linus Torvalds , Thomas Gleixner , Andrew Morton , Greg KH , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [GIT PATCH] TTY patches for 2.6.33-git Message-ID: <20091213113626.7a854941@lxorguk.ukuu.org.uk> In-Reply-To: <20091213065844.GA20244@elte.hu> References: <20091212084611.GA28266@elte.hu> <20091212013927.58d386d1.akpm@linux-foundation.org> <20091212101032.GB25286@elte.hu> <20091212023603.93768833.akpm@linux-foundation.org> <20091212214235.31429790@lxorguk.ukuu.org.uk> <20091213065844.GA20244@elte.hu> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.6; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 30 > earth4:~/tip> git checkout linus > Date: Fri Dec 11 20:58:20 2009 -0800 > earth4:~/tip> git grep -w unlock_kernel | wc -l > 841 > > we grew the (absolute) number of BKL sites by ~15%. Certainly the kernel grew > at a much faster rate, so the relative proportion of the BKL shrunk. Thats actually very misleading. The reason is we have created more lock/unlock points as we remove and drive down the lock. By your metric the original SMP kernel was best - it had one of each 8) > Also, a lot of BKL use was hidden before, and due to the BKL removal > activities (by Thomas, Frederic, Jon, Alan and others) the remaining BKL using > sites are a lot more well defined, a lot more isolated and thus a lot more > removable than ever before. ioctl is almost done and I've gont some other random ones in my tree. lseek is close. At that point most of the nasties are squashed except tty. We do have some remaining locking horrors some partly introduced by the finer locking work in the past including the rather nasty device unload/load v open file handle races. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/