Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754003AbZLMTUN (ORCPT ); Sun, 13 Dec 2009 14:20:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753866AbZLMTUM (ORCPT ); Sun, 13 Dec 2009 14:20:12 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:54417 "HELO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753985AbZLMTUK (ORCPT ); Sun, 13 Dec 2009 14:20:10 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Kb5rK28DpKc+J3v9YFvm9wwvP1EvQcnCrON5cxz70o/TJ1cbUMA+HzYneaCs3RRCIW MkwYqi2NmfrW8ssYzLB73VF4ru/A3qy/ACK+CK3e1eBpiwWwkcyhHSlTMqVKhF7ucbuR xzyTPSb6p4yaO0EmPH1ZpTDWeWPxvXQvAOEq0= Date: Sun, 13 Dec 2009 20:20:05 +0100 From: Frederic Weisbecker To: Trond Myklebust Cc: Ingo Molnar , Linus Torvalds , Thomas Gleixner , Alan Cox , Andrew Morton , Greg KH , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [GIT PATCH] TTY patches for 2.6.33-git Message-ID: <20091213192003.GC7297@nowhere> References: <20091212214235.31429790@lxorguk.ukuu.org.uk> <20091213065844.GA20244@elte.hu> <20091213181726.GA14558@elte.hu> <20091213190410.GA7297@nowhere> <1260731354.2612.14.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1260731354.2612.14.camel@localhost> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1140 Lines: 39 On Sun, Dec 13, 2009 at 02:09:14PM -0500, Trond Myklebust wrote: > On Sun, 2009-12-13 at 20:04 +0100, Frederic Weisbecker wrote: > > In the above cases we have the following comment: > > > > /* Protect inode->i_flock using the BKL */ > > > > And really it doesn't seem to protect anything else, > > fortunately it is acquired in a short path. > > As I said in my reply, this is the tough one, because the BKL protection > is imposed by the VFS locking scheme used in fs/locks.c. > > There is a similar dependency imposed upon fs/lockd/ Ok. > > fs/nfs/super.c: unlock_kernel(); > > fs/nfs/super.c: unlock_kernel(); > > > > Protect the mount/unmount path, a bit trickier there. > > > > But really that looks way much easier to fix than it was > > with reiserfs. > > All the other cases you list should be fixed in the GIT PULL request > that I just put out. > Cool, thanks a lot! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/