Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756140AbZLNAVq (ORCPT ); Sun, 13 Dec 2009 19:21:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756135AbZLNAVm (ORCPT ); Sun, 13 Dec 2009 19:21:42 -0500 Received: from [76.245.85.235] ([76.245.85.235]:39865 "EHLO cynthia.pants.nu" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751535AbZLNAVl (ORCPT ); Sun, 13 Dec 2009 19:21:41 -0500 X-Greylist: delayed 1916 seconds by postgrey-1.27 at vger.kernel.org; Sun, 13 Dec 2009 19:21:40 EST Date: Sun, 13 Dec 2009 15:49:09 -0800 From: Brad Boyer To: David Howells Cc: Geert Uytterhoeven , James Morris , Linux/m68k , Mike Frysinger , Chris Zankel , Linux Kernel Development , linux-security-module@vger.kernel.org Subject: Re: [PATCH] Keys: KEYCTL_SESSION_TO_PARENT needs TIF_NOTIFY_RESUME architecture support Message-ID: <20091213234909.GA10609@cynthia.pants.nu> References: <21796.1260743776@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21796.1260743776@redhat.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 606 Lines: 19 On Sun, Dec 13, 2009 at 10:36:16PM +0000, David Howells wrote: > Geert Uytterhoeven wrote: > > > +#warning TIF_NOTIFY_RESUME not implemented > > + return -EOPNOTSUPP; > > I wonder if it should printk() too. I would think something like WARN_ONCE() or something rate limited would be more appropriate. Brad Boyer flar@allandria.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/