Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901AbZLNBk1 (ORCPT ); Sun, 13 Dec 2009 20:40:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751224AbZLNBkV (ORCPT ); Sun, 13 Dec 2009 20:40:21 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:45965 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbZLNBkT (ORCPT ); Sun, 13 Dec 2009 20:40:19 -0500 Date: Sun, 13 Dec 2009 17:40:20 -0800 (PST) Message-Id: <20091213.174020.26980813.davem@davemloft.net> To: wg@grandegger.com Cc: geert@linux-m68k.org, chripell@fsfe.org, urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: CAN_MCP251X should depend on HAS_DMA From: David Miller In-Reply-To: <4B2552C8.4090105@grandegger.com> References: <4B2552C8.4090105@grandegger.com> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 16 From: Wolfgang Grandegger Date: Sun, 13 Dec 2009 21:47:04 +0100 > DMA can be selected with the module parameter "mcp251x_enable_dma" and > is *off* by default. Therefore the driver does in principle not depend > on HAS_DMA but I'm not sure if it's worth to handle it with #idef's. > Christian? Any thought? I still think it's a reasonable dependency. You're not going to find this device on a s390 system. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/