Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757214AbZLNMYH (ORCPT ); Mon, 14 Dec 2009 07:24:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757183AbZLNMYG (ORCPT ); Mon, 14 Dec 2009 07:24:06 -0500 Received: from mail-fx0-f213.google.com ([209.85.220.213]:42078 "EHLO mail-fx0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757098AbZLNMYB (ORCPT ); Mon, 14 Dec 2009 07:24:01 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Po3QEFOn6xowIoe2XGuHbsfY68I69Rc80ge73TnSsdGfvgFkmt+PRSaUwRQGS+YRdR gSVbPRl7J58OYToU+TU7Cgqj0n2bt+lYiUDQ/HdoTvw2B1o9PufqRAECjK53E0nKEdYM PXZYoJRC8jOQaVlGJS0yF9vF0q+5Y/GbDKrrU= Date: Mon, 14 Dec 2009 13:23:56 +0100 From: Frederic Weisbecker To: Li Zefan Cc: Steven Rostedt , Ingo Molnar , Wenji Huang , LKML Subject: Re: [PATCH 2/4] tracing/filters: Fix MATCH_FULL filter matching for PTR_STRING Message-ID: <20091214122354.GJ5168@nowhere> References: <4B2217D0.5000308@cn.fujitsu.com> <4B2217EA.4010902@cn.fujitsu.com> <20091211120753.GE5244@nowhere> <4B2597A8.7020909@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B2597A8.7020909@cn.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1478 Lines: 38 On Mon, Dec 14, 2009 at 09:40:56AM +0800, Li Zefan wrote: > Frederic Weisbecker wrote: > > On Fri, Dec 11, 2009 at 05:59:06PM +0800, Li Zefan wrote: > >> MATCH_FULL matching for PTR_STRING is not working correctly: > >> > >> # echo 'func == vt' > events/bkl/lock_kernel/filter > >> # echo 1 > events/bkl/lock_kernel/enable > >> ... > >> # cat trace > >> Xorg-1484 [000] 1973.392586: lock_kernel: ... func=vt_ioctl() > >> gpm-1402 [001] 1974.027740: lock_kernel: ... func=vt_ioctl() > >> > >> We should pass to regex.match(..., len) the length (including '\0') > >> of the source string instead of the length of the pattern string. > >> > >> Signed-off-by: Li Zefan > > > > This patch is cool but it seems to also break middle and end > > matching (at least what was working with end matching :) > > > > No, it won't, unless I miss something. > > I changed what value ptr_string passes the length param to match(), > but this param is not used in match_middle and match_end. > > It does break match_front for ptr_string, but that's because > the mixture of 2 bugs happened to make things right. I can > sort this out by reordering the 2 patches. No, no need to. I was just confused :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/