Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756637AbZLNNQx (ORCPT ); Mon, 14 Dec 2009 08:16:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755877AbZLNNQw (ORCPT ); Mon, 14 Dec 2009 08:16:52 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:51322 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755500AbZLNNQv convert rfc822-to-8bit (ORCPT ); Mon, 14 Dec 2009 08:16:51 -0500 From: "Shilimkar, Santosh" To: "felipe.balbi@nokia.com" CC: "linux-kernel@vger.kernel.org" , Linux OMAP Mailing List , Tony Lindgren , "Koskinen Aaro (Nokia-D/Helsinki)" , David Brownell , Linux USB Mailing List , Anton Vorontsov , Grazvydas Ignotas , "Chikkature Rajashekar, Madhusudhan" , Greg Kroah-Hartman , Mark Brown , Samuel Ortiz Date: Mon, 14 Dec 2009 18:46:13 +0530 Subject: RE: [RFC/PATCH 2/4] input: misc: twl4030: move to request_threaded_irq Thread-Topic: [RFC/PATCH 2/4] input: misc: twl4030: move to request_threaded_irq Thread-Index: Acp8skmcLD8pGuttR5aw8S8QQL0XSQACynAw Message-ID: References: <20091212183410.GF3092@sirena.org.uk> <1260786654-13294-3-git-send-email-felipe.balbi@nokia.com> <20091214114009.GI12526@nokia.com> In-Reply-To: <20091214114009.GI12526@nokia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1614 Lines: 36 > -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@nokia.com] > Sent: Monday, December 14, 2009 5:10 PM > To: Shilimkar, Santosh > Cc: Balbi Felipe (Nokia-D/Helsinki); linux-kernel@vger.kernel.org; Linux OMAP Mailing List; Tony > Lindgren; Koskinen Aaro (Nokia-D/Helsinki); David Brownell; Linux USB Mailing List; Anton Vorontsov; > Grazvydas Ignotas; Chikkature Rajashekar, Madhusudhan; Greg Kroah-Hartman; Mark Brown; Samuel Ortiz > Subject: Re: [RFC/PATCH 2/4] input: misc: twl4030: move to request_threaded_irq > > Hi, > > On Mon, Dec 14, 2009 at 12:31:11PM +0100, ext Shilimkar, Santosh wrote: > >In whole of the series the ISR you have converted to threads using threaded_irq are very > >small in size. They are like quick_change_handlers. So only advantage is the particular > >interrupt is masked for bit longer than with you change. > > > >I might be wrong here but it might introduce the spurious IRQ's because > >of bit of delay in the processing.What is the motive for this change ? > >Are we using this API as it suppose to be ? > > the irq chip is connected through i2c and that mandate us to handle irqs > in thread context. Now that we have kernel-wise api for that, we're just > moving towards it instead of definint our own stuff and the lockdep > shortcuts we had to put before. OK. I see your point now. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/