Message-ID: <4B265C34.6070205@trash.net>
Date: Mon, 14 Dec 2009 16:39:32 +0100
From: Patrick McHardy <kaber@trash.net>
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701)
MIME-Version: 1.0
To: Simon Horman <horms@verge.net.au>
CC: Xiaotian Feng <dfeng@redhat.com>, netdev@vger.kernel.org,
       lvs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
       Wensong Zhang <wensong@linux-vs.org>, Julian Anastasov <ja@ssi.bg>,
       "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ipvs: fix synchronization on connection close
References: <1260434502-14166-1-git-send-email-dfeng@redhat.com> <20091211033542.GA28136@verge.net.au>
In-Reply-To: <20091211033542.GA28136@verge.net.au>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1114
Lines: 27

Simon Horman wrote:
> On Thu, Dec 10, 2009 at 04:41:42PM +0800, Xiaotian Feng wrote:
>> commit 9d3a0de makes slaves expire as they would do on the master
>> with much shorter timeouts. But it introduces another problem:
>> When we close a connection, on master server the connection became
>> CLOSE_WAIT/TIME_WAIT, it was synced to slaves, but if master is
>> finished within it's timeouts (CLOSE), it will not be synced to
>> slaves. Then slaves will be kept on CLOSE_WAIT/TIME_WAIT until
>> timeout reaches. Thus we should also sync with CLOSE.
>>
>> Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
>> Cc: Wensong Zhang <wensong@linux-vs.org>
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Julian Anastasov <ja@ssi.bg>
>> Cc: David S. Miller <davem@davemloft.net>
> 
> This seems reasonable to me.
> 
> Acked-by: Simon Horman <horms@verge.net.au>

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/