Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755954AbZLNSir (ORCPT ); Mon, 14 Dec 2009 13:38:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752595AbZLNSio (ORCPT ); Mon, 14 Dec 2009 13:38:44 -0500 Received: from mga02.intel.com ([134.134.136.20]:42110 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbZLNSin (ORCPT ); Mon, 14 Dec 2009 13:38:43 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.47,395,1257148800"; d="scan'208";a="475941053" Subject: Re: [PATCH] acpi: fix for lapic_timer_propagate_broadcast() From: Suresh Siddha Reply-To: Suresh Siddha To: Hidetoshi Seto Cc: "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Brown, Len" In-Reply-To: <4B25F2DE.4000703@jp.fujitsu.com> References: <4B25F2DE.4000703@jp.fujitsu.com> Content-Type: text/plain Organization: Intel Corp Date: Mon, 14 Dec 2009 10:37:22 -0800 Message-Id: <1260815843.4243.1.camel@sbs-t61.sc.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2027 Lines: 57 On Mon, 2009-12-14 at 00:10 -0800, Hidetoshi Seto wrote: > I got following warning on ia64 box: > In function 'acpi_processor_power_verify': > 642: warning: passing argument 2 of 'smp_call_function_single' from > incompatible pointer type > > This smp_call_function_single() was introduced by a commit > f833bab87fca5c3ce13778421b1365845843b976: > > > @@ -162,8 +162,9 @@ > > pr->power.timer_broadcast_on_state = state; > > } > > > > -static void lapic_timer_propagate_broadcast(struct acpi_processor *pr) > > +static void lapic_timer_propagate_broadcast(void *arg) > > { > > + struct acpi_processor *pr = (struct acpi_processor *) arg; > > unsigned long reason; > > > > reason = pr->power.timer_broadcast_on_state < INT_MAX ? > > @@ -635,7 +636,8 @@ > > working++; > > } > > > > - lapic_timer_propagate_broadcast(pr); > > + smp_call_function_single(pr->id, lapic_timer_propagate_broadcast, > > + pr, 1); > > > > return (working); > > } > > The problem is that the lapic_timer_propagate_broadcast() has 2 versions: > One is real code that modified in the above commit, and the other is NOP > code that used when !ARCH_APICTIMER_STOPS_ON_C3: > > static void lapic_timer_propagate_broadcast(struct acpi_processor *pr) { } > > So I got warning because of !ARCH_APICTIMER_STOPS_ON_C3. > > We really want to do nothing here on !ARCH_APICTIMER_STOPS_ON_C3, so > modify lapic_timer_propagate_broadcast() of real version to use > smp_call_function_single() in it. > > Signed-off-by: Hidetoshi Seto Acked-by: Suresh Siddha Len, please push this in to your tree. thanks, suresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/