Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757366AbZLNTFw (ORCPT ); Mon, 14 Dec 2009 14:05:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757253AbZLNTFv (ORCPT ); Mon, 14 Dec 2009 14:05:51 -0500 Received: from cavan.codon.org.uk ([93.93.128.6]:49621 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757176AbZLNTFv (ORCPT ); Mon, 14 Dec 2009 14:05:51 -0500 Date: Mon, 14 Dec 2009 19:05:44 +0000 From: Matthew Garrett To: Jens Axboe Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] laptop-mode: Make flushes per-device Message-ID: <20091214190544.GA6589@srcf.ucam.org> References: <20091211164433.GA1980@srcf.ucam.org> <1260554071-2190-1-git-send-email-mjg@redhat.com> <20091212122443.GA8742@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091212122443.GA8742@kernel.dk> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 742 Lines: 20 On Sat, Dec 12, 2009 at 01:24:43PM +0100, Jens Axboe wrote: > That's because it is messy, why are you passing the request in? It > would be a lot more sane to pass in the queue, better still the backing > device. It seemed conceptually cleaner for the completion to refer to the request rather than anything else, but that's easily fixed. > What guarentees that the timer isn't running when the bdi goes away? Good point. I'll fix these and resend. -- Matthew Garrett | mjg59@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/