Date: Mon, 14 Dec 2009 20:08:27 +0100
From: Jens Axboe <jens.axboe@oracle.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] laptop-mode: Make flushes per-device
Message-ID: <20091214190827.GS8742@kernel.dk>
References: <20091211164433.GA1980@srcf.ucam.org> <1260554071-2190-1-git-send-email-mjg@redhat.com> <20091212122443.GA8742@kernel.dk> <20091214190544.GA6589@srcf.ucam.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091214190544.GA6589@srcf.ucam.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1073
Lines: 29

On Mon, Dec 14 2009, Matthew Garrett wrote:
> On Sat, Dec 12, 2009 at 01:24:43PM +0100, Jens Axboe wrote:
> 
> > That's because it is messy, why are you passing the request in? It
> > would be a lot more sane to pass in the queue, better still the backing
> > device.
> 
> It seemed conceptually cleaner for the completion to refer to the 
> request rather than anything else, but that's easily fixed.

It's rather a major layering violation, I would claim... Passing in the
bdi is design wise the cleanest.

> > What guarentees that the timer isn't running when the bdi goes away?
> 
> Good point. I'll fix these and resend.

Thanks! As you can tell, laptop mode was pretty much for a laptop with a
single drive back when it was created. It definitely seems like a good
idea to make it per-drive granular now.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/