Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbZLNThi (ORCPT ); Mon, 14 Dec 2009 14:37:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752166AbZLNThh (ORCPT ); Mon, 14 Dec 2009 14:37:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22462 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbZLNThh (ORCPT ); Mon, 14 Dec 2009 14:37:37 -0500 Date: Mon, 14 Dec 2009 20:31:32 +0100 From: Oleg Nesterov To: Peter Zijlstra Cc: Roland McGrath , Alexey Dobriyan , Ananth Mavinakayanahalli , Christoph Hellwig , "Frank Ch. Eigler" , Ingo Molnar , linux-kernel@vger.kernel.org, utrace-devel@redhat.com Subject: Re: [RFC,PATCH 14/14] utrace core Message-ID: <20091214193132.GA14124@redhat.com> References: <20091124200220.GA5828@redhat.com> <1259697242.1697.1075.camel@laptop> <20091214002533.3052519@magilla.sf.frob.com> <1260798696.4165.316.camel@twins> <20091214174127.GA9315@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091214174127.GA9315@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 20 On 12/14, Oleg Nesterov wrote: > > IOW, we must ensure that if ever clear TIF_NOTIFY_RESUME we must not > miss ->pending_attach, correct? and for this case we have mb() after > clear_thread_flag(). Perhaps instead we should add mb__after_clear_bit() > into arch/ hooks, but this needs a lot of arch-dependent changes. Cough. And I always read this "rmb" as "mb". Even when I changed the comment to explain that we need a barrier between clear bit and read flags, I didn't notice it is in fact rmb... I guess we need the trivial fix, Roland? Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/