Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758580AbZLNWDX (ORCPT ); Mon, 14 Dec 2009 17:03:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758561AbZLNWDN (ORCPT ); Mon, 14 Dec 2009 17:03:13 -0500 Received: from smtp.nokia.com ([192.100.122.230]:36540 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758537AbZLNWDJ (ORCPT ); Mon, 14 Dec 2009 17:03:09 -0500 Date: Tue, 15 Dec 2009 00:02:20 +0200 From: Felipe Balbi To: "ext Rick L. Vinyard Jr." Cc: "linux-kernel@vger.kernel.org" , "krzysztof.h1@wp.pl" , "akpm@linux-foundation.org" , "linux-usb@vger.kernel.org" , "oliver@neukum.org" , "linux-input@vger.kernel.org" , "jkosina@suse.cz" Subject: Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others) Message-ID: <20091214220220.GB2052@nokia.com> Reply-To: felipe.balbi@nokia.com References: <200912142122.nBELMW7d001243@mustang.cs.nmsu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <200912142122.nBELMW7d001243@mustang.cs.nmsu.edu> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginalArrivalTime: 14 Dec 2009 22:02:45.0617 (UTC) FILETIME=[2A969610:01CA7D09] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 51 Hi, On Mon, Dec 14, 2009 at 10:22:32PM +0100, ext Rick L. Vinyard Jr. wrote: > >Signed-off-by: Rick L. Vinyard, Jr there are plenty of style mistakes in this patch. the body message description which you put below should be above the signed-off-by line, multi-lined comments are of the form: /* * multi lined comment * goes here */ remove the commented code like /* hid_debug = 0 */ and some others.. please run your patch through scripts/checkpatch.pl --strict and fix the errors and warnings reported. please take a look at Documentation/SubmittingPatches and Documentation/CodingStyle for further reference. When sending the patch, you could also use git send-email to avoid the problem you had with 'mail'. >+static int __init g13_init(void) >+{ >+ pr_debug("g13 HID driver loaded"); don't pr_debug() here. >+ return hid_register_driver(&g13_driver); >+} >+ >+static void __exit g13_exit(void) >+{ >+ pr_debug("g13 HID driver unloaded"); nor here. >+ hid_unregister_driver(&g13_driver); >+} -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/