Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758699AbZLNWtv (ORCPT ); Mon, 14 Dec 2009 17:49:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758656AbZLNWtt (ORCPT ); Mon, 14 Dec 2009 17:49:49 -0500 Received: from mail.cs.nmsu.edu ([128.123.64.3]:37034 "EHLO mail.cs.nmsu.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758591AbZLNWts (ORCPT ); Mon, 14 Dec 2009 17:49:48 -0500 Message-ID: In-Reply-To: <20091214220220.GB2052@nokia.com> References: <200912142122.nBELMW7d001243@mustang.cs.nmsu.edu> <20091214220220.GB2052@nokia.com> Date: Mon, 14 Dec 2009 15:48:43 -0700 Subject: Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others) From: "Rick L. Vinyard, Jr." To: felipe.balbi@nokia.com Cc: "linux-kernel@vger.kernel.org" , "krzysztof.h1@wp.pl" , "akpm@linux-foundation.org" , "linux-usb@vger.kernel.org" , "oliver@neukum.org" , "linux-input@vger.kernel.org" , "jkosina@suse.cz" User-Agent: SquirrelMail/1.4.19 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 69 Hello, Felipe Balbi wrote: > On Mon, Dec 14, 2009 at 10:22:32PM +0100, ext Rick L. Vinyard Jr. wrote: >> >>Signed-off-by: Rick L. Vinyard, Jr > > there are plenty of style mistakes in this patch. the body message > description which you put below should be above the signed-off-by line, Fixed in the new patch labelled 0.0.2 > multi-lined comments are of the form: > > /* > * multi lined comment > * goes here > */ > Fixed > remove the commented code like /* hid_debug = 0 */ > Removed > and some others.. please run your patch through scripts/checkpatch.pl > --strict and fix the errors and warnings reported. > I ran it without the --strict option before. That's probably why I didn't catch it. It's clean now with --strict. >>+static int __init g13_init(void) >>+{ >>+ pr_debug("g13 HID driver loaded"); > > don't pr_debug() here. > Removed >>+ return hid_register_driver(&g13_driver); >>+} >>+ >>+static void __exit g13_exit(void) >>+{ >>+ pr_debug("g13 HID driver unloaded"); > > nor here. > >>+ hid_unregister_driver(&g13_driver); >>+} Removed Thanks for the input. Everything above is taken into account in v0.0.2 of the patch. --- Rick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/